Skip to content

Bug fix: German Transit #3023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 14, 2025
Merged

Bug fix: German Transit #3023

merged 6 commits into from
May 14, 2025

Conversation

kmartinez834
Copy link
Contributor

Bug fix:

  • Description of bug: No suggested stations appeared when location was submitted on live app
  • Fix: Order of coordinates in the name_sf param of fetch_stations were switched

Improvement:

  • Added default station so preview includes actual upcoming departures, rather than "No station selected"

@tidbyt
Copy link

tidbyt bot commented Apr 23, 2025 •
edited
Loading

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
✅ App Dir All files are in a single app directory
🟡 Modules Usage of http.star requires review
✅ Original Author The original author matches the PR author

drudge
drudge requested changes May 12, 2025
View reviewed changes
Copy link
Collaborator

@drudge drudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter is complaining

@drudge drudge self-requested a review May 14, 2025 19:51
@drudge drudge merged commit d04f08e into tidbyt:main May 14, 2025
2 checks passed
@tidbyt tidbyt locked as resolved and limited conversation to collaborators May 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@drudge drudge drudge approved these changes

@danielsitnik danielsitnik Awaiting requested review from danielsitnik danielsitnik is a code owner

@matslina matslina Awaiting requested review from matslina matslina is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmartinez834 @drudge